[NUI][WIP] Migrate DllImport to LibraryImport in NUI modules#7513
Draft
hinohie wants to merge 1 commit intoSamsung:DevelNUIfrom
Draft
[NUI][WIP] Migrate DllImport to LibraryImport in NUI modules#7513hinohie wants to merge 1 commit intoSamsung:DevelNUIfrom
hinohie wants to merge 1 commit intoSamsung:DevelNUIfrom
Conversation
1. Add `global::System.Runtime.InteropServices` at top of Interop files so reduce length of codes. 2. Change input parameter of native bind function input from `HandleRef` to `IntPtr`. Also change the bind function caller use IntPtr. 3. Change extern to partial for Iterop classes, and change `DllImport` to `LibraryImport`. 4. Use `StringMarshalling = StringMarshalling.Utf8` keyword for eacy library import. 5. Add `[MarshalAs(UnmanagedType.U1)]` if native bind function's input parameter is bool type. Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
Collaborator
Build Error: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
global::System.Runtime.InteropServicesat top of Interop files so reduce length of codes.HandleReftoIntPtr. Also change the bind function caller use IntPtr.DllImporttoLibraryImport.StringMarshalling = StringMarshalling.Utf8keyword for eacy library import.[MarshalAs(UnmanagedType.U1)]if native bind function's input parameter is bool type.Description of Change
API Changes